search

developit / web-worker

Consistent Web Workers in browser and Node.
https://npm.im/web-worker
Apache License 2.0
1.06k stars 55 forks source link

always use file:// urls because of Windows #38

Open mmomtchev opened 1 year ago

mmomtchev commented 1 year ago

Fixes #35

Firegarden commented 1 year ago

This does not address the fix in commonjs version

As far as I have tested line 201 of cjs\node.js needs to incorporate the same fix eg import(URL.pathToFileURL(mod)).catch(err => {

Firegarden commented 1 year ago

I am confirming you can patch 2 lines of local package code to get this working as per Fixes 35

line 178 of node.js becomes import(URL.pathToFileURL(mod))

also you need patch line 201 of cjs\node.js import(URL.pathToFileURL(mod)).catch(err => {

this library is great to save you from learning node worker threads and thread pools

Juliiiian commented 1 year ago

i dont know if your still reading this but the fix is enough since on build the cjs/node.js will be created so its fine.

just sad to see that the prs are not getting merged

mmomtchev commented 1 year ago

@Juliiiian alas, the fight for a European judicial system free of criminals is more important than this or that PR