developit / workerize-loader

🏗️ Automatically move a module into a Web Worker (Webpack loader)
https://npm.im/workerize-loader
2.31k stars 86 forks source link

Duplicate worker code inside bundle file with inline option #129

Open Stukova opened 2 years ago

Stukova commented 2 years ago

Hi!

When using inline option in the config, I found duplicate worker code in my bundle. Perhaps this is because of incorrect use of createObjectURL and revokeObjectURL in the case of inline: true option. I believe in line 186 👇, the argument of URL.revokeObjectURL should not be a string with all the worker code inside it, but it should be a product of URL.createObjectURL method.

https://github.com/developit/workerize-loader/blob/99d98e4f14e83cff28b9269660964d5424d865bb/src/index.js#L186