search

developmentseed / aep

Africa Electrification Platform - a project for the World Bank
MIT License
4 stars 5 forks source link

Liberia custom #66

Closed danielfdsilva closed 2 years ago

danielfdsilva commented 3 years ago

@akorkovelos can you please push your changes so I can see the same codebase?

danielfdsilva commented 3 years ago

@akorkovelos with the new changes everything seems to work fine. To ensure you're not running the project with cached data, run yarn clean before yarn serve when executing locally.

I looked into the population layer, and it loads well albeit taking quite some time. It is a fairly large file (5.2MB) which takes time to be downloaded. In this case you're using a geojson directly so the system has to download the whole data before rendering it on the map. It would make more sense to use a vector source, where each tile is downloaded and rendered individually. This would speed up the process.

akorkovelos commented 3 years ago

Thanks @danielfdsilva, yarn clean solved the issue for me; everything is rendered on the map now. I don't have an issue with the loading speed of population when run locally, but I 'll keep in mind your suggestion for future applications.

akorkovelos commented 3 years ago

Hi @danielfdsilva any idea why the final check does not work here? It seems that everything works fine when I deploy localy. Thanks

danielfdsilva commented 3 years ago

@akorkovelos Turns out there was a bug in the validator script. Instead of looking for a list on items under displayData it was looking for a single one. I fixed this ans pushed a commit.

The validator runs as part of the CI tests, but you can also run it locally (using yarn validate) before pushing to ensure that everything is ok.

shakythesherpa commented 2 years ago

This pull request is no longer needed. A new pull request for Liberia has been merged already.