developmentseed / bioacoustics-frontend

Frontend code for the Google Bioacoustics project that's used by A2O Search
https://search.acousticobservatory.org/
MIT License
2 stars 0 forks source link

Fix player pos #43

Closed oliverroick closed 1 year ago

oliverroick commented 1 year ago

Two bug fixes with zooming and panning the spectrogram:

LanesGood commented 1 year ago

I think this is properly fixing the two issues noted, but I'm not 100% certain. I still see two issues which may be separate and unrelated, but noting here in case these can/should be covered by the same fix.

Before diving too deeply into these, would it also be useful/beneficial to check out the wavesurfer playhead plugin, which indicates time and may also have the functionality required to mitigate these fixes by default?

  1. When I click + drag on the spectrogram itself while the audio is playing, whether I'm zoomed in or out, I do see the time indicator moving back and forth.

https://github.com/developmentseed/bioacoustics-frontend/assets/12634024/63bcc30f-688c-4f72-891e-1bfddb2f17a8

  1. When I zoom in, and then move my mouse to the spectrogram, it seems like the mouse is still in a "grab/drag" mode

https://github.com/developmentseed/bioacoustics-frontend/assets/12634024/03363b50-4d0a-4886-9997-a325c6a0f607

oliverroick commented 1 year ago

@LanesGood It's best to address these two issues separately from this work. I created tickets for both