import eoapi-cdk constructs and reuse them - Githubissues

developmentseed / eoAPI

[Active Development] Earth Observation API (Metadata, Raster and Vector services)

https://eoapi.dev

MIT License

191 stars 20 forks source link

import eoapi-cdk constructs and reuse them #144

Closed emileten closed 8 months ago

emileten commented 9 months ago

Another take at https://github.com/developmentseed/eoAPI/pull/135. This one is much simpler. All modifications are in infrastructure/aws, and are all about swapping direct native AWS CDK calls with eoapi-cdk construct calls.

There is no change in behavior in this PR ; i.e, the deployed infrastructure should be identical for a given set of environment variables after this PR is merged.

The code in this branch synthesized successfully and I'm trying to deploy right now.

emileten commented 9 months ago

One significant difference with the other PR, in addition, is that I'm not adding the ingestor & browser, I'd like to keep things simple and do that later in another PR if possible.

emileten commented 9 months ago

Looks like it mostly works, here are links of services vector, stac, raster.

There is just some formatting left to be done and then we should try to deploy to the existing staging and see if anything gets broken.

vincentsarago commented 9 months ago

One significant difference with the other PR, in addition, is that I'm not adding the ingestor & browser, I'd like to keep things simple and do that later in another PR if possible.

🙏 yeah we def want stac-browser and ingestor to be deployed but 👍 for doing it later :-)

emileten commented 8 months ago

@vincentsarago this is ready to be merged. Important notes :

I deployed this to a stack named eoapi-dev in the devseed account. I swapped the domain mappings : *.eoapi.dev point to APIs in this stack (I copied the content of the DB over).
removed the NAT gateway (and made corresponding necessary networking changes we discussed on slack).
added the STAC ingestor. I created a custom domain name for this with a record at ingestor.eoapi.dev, for now it's not working but we might need to wait -- otherwise it's available at the non custom URL that's shown in the stack.
added the STAC browser, see this public endpoint : http://eoapi-dev-stac-browser.s3-website-us-east-1.amazonaws.com.

emileten commented 8 months ago

When you're 👍 I can merge and later delete the eoapi-staging stack.

emileten commented 8 months ago

Edit : ingestor.eoapi.dev works now

vincentsarago commented 8 months ago

@emileten I'm getting an error at https://ingestor.eoapi.dev/docs is that expected?

emileten commented 8 months ago

@vincentsarago Yes the /docs is broken in the custom domain name, there is a ticket for this in eoAPI-cdk. I'll try to fix that tomorrow.

You can reach /docs with the api gateway url though (not on my computer right now, but that url is one of the outputs of the stack).

emileten commented 8 months ago

@vincentsarago

🤔 can we avoid setting a default to our stack here?

☝️ done

the /docs is broken

☝️ fixed https://ingestor.eoapi.dev/docs with https://github.com/developmentseed/eoapi-cdk/pull/82