developmentseed / eoAPI

[Active Development] Earth Observation API (Metadata, Raster and Vector services)
https://eoapi.dev
MIT License
206 stars 22 forks source link

Fix tuple destructuring overriding class id member. #41

Closed sharkinsspatial closed 2 years ago

sharkinsspatial commented 2 years ago

What I am changing

The variable name used in tuple de-structuring is overriding the class id member resulting in incorrect resource names within the stack. For a simplified example

id = "an_id"
print(id)
gateway_endpoints = [("S3", "s3_service")]
for (id, service) in gateway_endpoints:
    print(service)
print(id)

How I did it

Changed the name of the de-structuring variable to key

How you can test it

Deploy the stack.

vincentsarago commented 2 years ago

🤦 good catch @sharkinsspatial 🙏