search

developmentseed / eoapi-risk

An implementation of eoAPI for Risk data and the Humanitarian sector
MIT License
2 stars 0 forks source link

minor fixes for missing properties in new collection imports #40

Closed batpad closed 10 months ago

batpad commented 10 months ago

@zacharyDez I'm. not sure if there's a better way to PR just the relevant changes to the ipnyb file, since a lot of the diff here is not really related to the changes I made.

The relevant changes I made are just:

"print(f\"{collection_info['title'] if 'title' in collection_info else 'NA'}: {collection_info['description']}\")" <-- added the if "title" ... since I think some of the newer collection imports are missing the title field.

for bbox in collection_info[\"extent\"][\"spatial\"][\"bbox\"] if \"extent\" in collection_info\n <-- again added the if "extent"... since it seems like that was failing for some collections.

I made those two changes on the notebook, re-ran to verify things worked, and then downloaded the notebook. Ofcourse, the ipnyb has added a bunch of things not related to my changes. Not sure of the best practice to diff / make changes here?

cc @geohacker

zacdezgeo commented 10 months ago

We often use this review notebook app. It might be worth setting up for future development.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB