search

developmentseed / geolambda

Create and deploy Geospatial AWS Lambda functions
MIT License
303 stars 85 forks source link

release 1.2.0 final #75

Closed matthewhanson closed 4 years ago

matthewhanson commented 4 years ago

final release

matthewhanson commented 4 years ago

@vincentsarago can you take a look at this and see if there's anything else that should be included in this version?

The current master branch is 1.2.0rc2, and those base and python Lambda layers are published, along with the images on Docker Hub.

The Layer ARNs provided on the develop branch don't yet exist, but once they are merged to master they would get published.

vincentsarago commented 4 years ago

@matthewhanson all seems ok. Only question, for PREFIX we use /usr/local/ (https://github.com/developmentseed/geolambda/blob/develop/Dockerfile#L36) so I'm wondering if we are ending up with a layer that has more files that the gdal/proj libs (meaning I think we are packaging files from lambci/lambda:build-provided image)

matthewhanson commented 4 years ago

The /usr/local directory isn't used by system files normally, it's for user built libraries. I just checked lambci/lambda:build-provided and the /usr/local/lib folder is empty except for python2.7 and python3.6 directories, there's no other .so files so the only ones installed are the ones built in the Dockerfile.

vincentsarago commented 4 years ago

👌 thus we still endup adding python2.7 and python3.6 dirs to the layer right ?

matthewhanson commented 4 years ago

No, it's just copying .so files:

cp -P ${PREFIX}/lib/*.so* $DEPLOY_DIR/lib/
cp -P ${PREFIX}/lib64/libjpeg*.so* $DEPLOY_DIR/lib/

and doesn't recurse into directories