search

developmentseed / housing-passports-v2

Project in collaboration with WB to improve housing resilience.
https://devseed.com/housing-passports-v2/docs/index.html
MIT License
2 stars 2 forks source link

triangulation: docker-compose not exactly reusable as-is #33

Closed jeanpommier closed 3 months ago

jeanpommier commented 5 months ago

Hi, I'm seeing something that makes the docker-compose file not reusable : https://github.com/developmentseed/housing-passports-v2/blob/main/triangulation/docker-compose.yml#L26

    volumes:
        - ./:/mnt/data
        - ./../../Downloads/:/host_files
        - ~/.aws:/root/.aws

It is mounting a path that is not on the repo (../../Downloads), this is not a good practice What is it used for ? Is it necessary ? Requires at least to be documented. Best, removed / modified. Same thing applies for the .aws file, but this one is easy to figure out. Thanks