developmentseed / housing-passports-v2

Project in collaboration with WB to improve housing resilience.
https://devseed.com/housing-passports-v2/docs/index.html
MIT License
2 stars 2 forks source link

mapillary token not escaped #36

Closed jeanpommier closed 3 months ago

jeanpommier commented 4 months ago

https://github.com/developmentseed/housing-passports-v2/blob/aba3dd12483f423e21da861ad14b310625849822/pre_processing/pre_processing.sh#L6-7 make use of a MAPILLARY_ACCESS_TOKEN.

The readme does not mention that you should have previously set this env var.

And, more troublesome, the env var is not escaped, in the script. Since mapillary tokens may include at least |special chars, it definitely needs to be escaped in order to work properly