search

developmentseed / jekyll-hook

No Longer Maintained | A server that listens for GitHub webhook posts and renders a Jekyll site
BSD 3-Clause "New" or "Revised" License
508 stars 83 forks source link

Phillipmartin validate x hub sig #20

Closed scisco closed 9 years ago

scisco commented 9 years ago

Merging #12 with master

parkr commented 9 years ago

Would you consider separating this out so it can be tested?

scisco commented 9 years ago

@parkr I did run some tests and it seems to be working fine. Did you notice any issues?

parkr commented 9 years ago

@parkr I did run some tests and it seems to be working fine. Did you notice any issues?

@scisco Nope! I was just thinking of a unit test. It doesn't look like jekyll-hook has any tests though so it may not make sense to add. I'm always one to rely on the wonders of continuous integration.

scisco commented 9 years ago

It's on my wish list to add some tests. I'll definitely work on it when I get a chance.