developmentseed / lonboard

A Python library for fast, interactive geospatial vector data visualization in Jupyter.
https://developmentseed.org/lonboard/latest/
MIT License
653 stars 33 forks source link

[BUG] Map overrides theme in VSC interactive display. #696

Open deanm0000 opened 1 month ago

deanm0000 commented 1 month ago

Context

When using lonboard in VSC jupyter interactive in dark mode, once I display a Map, the output for everything carries the theme of the Map of white background. Before running a map it looks like: image

Resulting behaviour, error message or logs

After having run a map it looks like this:

image

Environment

Platform: Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.35 Python: 3.12.2 (main, Feb 25 2024, 16:35:05) [GCC 11.4.0]

Steps to reproduce the bug

Using VSC with dark theme. Make a map then all cells get the Map's style, at least for background and font.

kylebarron commented 1 month ago

I don't particularly understand CSS styling and what's happening here. But it's also quite difficult to provide CSS that works as expected in every environment, when Jupyter/JupyterLab/Colab/vscode etc are all implemented in different ways. Happy to accept a PR or maybe @vgeorge has time at some point to look into this. (but lower priority than some bugs in the last release like https://github.com/developmentseed/lonboard/issues/675)

eKerney commented 1 week ago

Hello @kylebarron and @vgeorge I'm experiencing a similar issue with VSC and am wondering if there is any room to make a contribution on this? WSL2 ubuntu 22.04 - lonboard 0.10.3 - python 3.11.10

kylebarron commented 1 week ago

A fix here would be greatly appreciated!