search

developmentseed / moz-datapipeline

Mozambique Road Planning data pipeline
MIT License
4 stars 1 forks source link

Flood indicator #43

Closed olafveerman closed 6 years ago

olafveerman commented 6 years ago

@danielfdsilva Main calculation of EAD implemented. It only calculates EAD for a single scenario, we'll start with current.

Still missing is to fetch the data from S3, but this depends on #33 . @matthewhanson This is roughly what this script expects: https://github.com/developmentseed/moz-datapipeline/blob/feature/flood-indicator/scripts/vulnerability/roadnetwork_stats-sample.csv

olafveerman commented 6 years ago

Mock data is loaded from S3. This is ready to be merged in @danielfdsilva

olafveerman commented 6 years ago

Thanks for the review @danielfdsilva!

Fixed most of your comments. Regarding downloading from S3, you're right it would be more consistent with the other scripts. That said, we're not doing any other processing to the data except for downloading it. I'd be inclined to leave it now, and move it to preparation.sh if we need flood data for something else.