search

developmentseed / observe

Cross-platform, offline, field mapping tool for OpenStreetMap
ISC License
67 stars 5 forks source link

show deleted ways #310

Closed geohacker closed 4 years ago

geohacker commented 4 years ago

This PR completes #296 cc @LanesGood

LanesGood commented 4 years ago

@geohacker it appears the last two nodes of the way still exist, even though the way itself is deleted. Can you confirm whether this is expected behavior?

geohacker commented 4 years ago

@LanesGood yes, that's right. That's how deleted POIs also show up so I just matched the same. There'll be pendingDeleteUpload = true property on these features. So we could style these differently.

LanesGood commented 4 years ago

@geohacker this is the current case of deleting two nodes from a 4-node closed polygon:

way-poly-delete

Should we aim instead for the iD behavior for deleting a closed feature entirely if there are not three nodes?

geohacker commented 4 years ago

Should we aim instead for the iD behavior for deleting a closed feature entirely if there are not three nodes?

Thanks for pointing this out @LanesGood. I checked iD again and it's doing what you recommended. Deleting the way if it's a polygon and less than 3 nodes. @batpad do you think this will fit within the workflow of how we manage lines?