search

developmentseed / observe

Cross-platform, offline, field mapping tool for OpenStreetMap
ISC License
66 stars 5 forks source link

New nodes in existing ways persist after deletion in editing mode #321

Closed LanesGood closed 4 years ago

LanesGood commented 4 years ago

Adding new nodes to existing ways and then deleting these and surrounding nodes results in strange behaviors. Most of the time, these new nodes are still rendered even when the resulting way is altered. This is difficult to describe exactly how to reproduce, as I'm not sure what exactly is happening. Noting as well that I'm purposefully trying to break things, rather than reproduce a live use case.

new-node-delete-issue

The final result after attempting to save the changeset is also usually a console.error:"Error storing data", Error: database or disk is full (code 13 SQLITE_FULL) - this is on Android AVD,

This seems related to #289 #296 and #318

LanesGood commented 4 years ago

EDIT: Far less complex example indicates that this behavior is a consistent bug new-node-delete-bug

geohacker commented 4 years ago

@LanesGood nice catch. I think I know what could be going on here. The node itself is deleted from the feature (notice the change in the shape) but it's not hidden from the map because of a style filter issue. I can fix.

geohacker commented 4 years ago

console.error:"Error storing data", Error: database or disk is full (code 13 SQLITE_FULL)

This is unrelated to the nodes not getting deleted. This likely means the AVD hit the limit for async-storage. A reset should fix it.

geohacker commented 4 years ago

This is fixed in #322