search

developmentseed / osm-seed

A collection of Dockerfiles to run a containerized version of OpenStreetMap
https://devseed.com/osm-seed-chart/
MIT License
154 stars 36 forks source link

fix env var name for id key - OSM_id_key -> OPENSTREETMAP_id_key #303

Closed batpad closed 9 months ago

batpad commented 1 year ago

@Rub21 I think this env var needs to be OPENSTREETMAP_id_key, looking at https://github.com/developmentseed/osm-seed/blob/develop/images/web/start.sh#L31

I think we might have forgotten to update the example env after making these variable name changes recently?

Also, am not sure if we also need to change the OSM_memcache_servers variable name similarly at https://github.com/developmentseed/osm-seed/blob/develop/envs/.env.web.example#L29 ? I remember there being some changes we made to these names some point when upstream made some changes, but I forget the details a bit. Could you see if this makes sense and make any other changes to the env example I might have missed and we can merge this?

cc @majdal

majdal commented 1 year ago

I would also add something in the readme of that file that explains that iD editor is also being installed as a part of the package.

majdal commented 1 year ago

ALSO: seems like Google disabled the "allow less secure apps" option on gmail accounts as of last year, so as far as I can tell, the gmail option for email is no longer available... https://github.com/developmentseed/osm-seed/tree/develop/images/web#email-configuration