Enhancements to Profile forms

developmentseed / osm-teams

Teams for OpenStreetMap!

https://mapping.team

MIT License

26 stars 5 forks source link

Enhancements to Profile forms #264

Open kamicut opened 2 years ago

kamicut commented 2 years ago

From #259 review by @vgeorge

We should disallow modifying property type after it is created as there will be no way of parsing existing data (changing date to telephone, for e.g.)
There is no error message if property creation fails. I think we can fix this on a separate PR after https://github.com/developmentseed/osm-teams/pull/256 is merged, which includes toasts
A more accurate label for the button "Add your profile" might be "Edit your team profile"
If possible it would be good to move profiles keys table to a reusable component as it looks the same in org/team pages

jenningsanderson commented 2 years ago

2 thoughts on the profile page:

The "Create" button should be removed; this button offers options to create 'teams' or 'organizations' not profiles, so it's confusing.
In the row for a team, you should be able to edit your profile; perhaps something in the UI could offer feedback based on how much of the profile has been completed / if it exists yet to encourage mappers to complete their profile.

jenningsanderson commented 2 years ago

And then in the edit profile page, organization level attributes should always be visible for any team associated with that organization; if the 'org' name can be rendered as well, that might help people understand the difference between organizations and teams:

kamicut commented 1 year ago

@LanesGood has implemented "disallowing key_type modification" for existing attributes on the frontend in #423. We should also implement it in the API.