developmentseed / osm-teams

Teams for OpenStreetMap!
https://mapping.team
MIT License
26 stars 5 forks source link

Team Detail: Make table searchable and sortable #319

Open batpad opened 1 year ago

batpad commented 1 year ago

@LanesGood - there is a desire to make the table on the team detail page "searchable and sortable". Could you help outline here what that might involve UX wise and we can discuss how this fits / how best to proceed.

cc @jenningsanderson @kamicut @vgeorge

batpad commented 1 year ago

@jenningsanderson is this around making the list of users searchable? On the org page or the team page or both?

LanesGood commented 1 year ago

@vgeorge to start looking into adding react-table as a solution for search, sort, filtering, etc.

batpad commented 1 year ago

Based on discussion:

For users, we will try and use the display_name key in the profile, which should be populated with the user's OSM username.

This relates to #298

@vgeorge @kamicut can you add any notes about handling the OSM usernames in the database, any concerns, etc. - at this point, let us not worry about the case where a user changes their name in OSM. Hopefully this approach of storing the OSM usernames in the database can help with search, as well as reduce the need / dependency on OSM for the id -> username lookup.

batpad commented 1 year ago

Speaking to @kamicut, this is a bit more complex since we currently don't store display_names for users that are not signed up for OSM Teams (i.e. users can exist just as ids that are part of teams).

@kamicut - would you be able to outline your solution / how you're thinking about this a bit here?

vgeorge commented 1 year ago

Status update: we added pagination of staff and members to organizations pages and cache for username fetching from OpenStreetMap.

My suggested next steps for completing this ticket are: