search

developmentseed / osm-teams

Teams for OpenStreetMap!
https://mapping.team
MIT License
27 stars 5 forks source link

Update pagination button styles #377

Closed LanesGood closed 1 year ago

LanesGood commented 1 year ago

Minor style change to distinguish active page in pagination.

@willemarcel I also notice that pagination options are behaving strangely when there are only 2 pages. See below screenshot. Changing the PAGE_INDEX_START const to 0 didn't seem to help adjust this, though I see that we 0-indexed other examples of this pattern. Any ideas? image

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osm-teams ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 6:02PM (UTC)
LanesGood commented 1 year ago

update: found an example with just 3 pages - this also doesn't seem to be correct: image

willemarcel commented 1 year ago

@LanesGood I believe we don't need to add 1 to currentPage. Could you try to change it? If it doesn't work, we can have a call to debug it together. const pages = listPageOptions(currentPage + 1, maxPages)

LanesGood commented 1 year ago

@willemarcel no, that didn't seem to fix the issue