Closed LanesGood closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
osm-teams | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 11, 2023 at 2:45AM (UTC) |
@kamicut please feel free to add to/edit/contribute content for the about page in addition to review
@LanesGood thanks for the PR! In NextJS, we use the basePath
to ensure that Links are correctly formed https://nextjs.org/docs/api-reference/next.config.js/basepath, so we don't need to join the APP_URL
with the link path. Is this required for a specific reason in your commit?
@kamicut I was simply following the pattern established on other NextLinks throughout the app.
@kamicut per our conversation, I've removed all instances of joined APP_URL's from any Nextjs <Link> href
in the latest commit.
This PR:
<Link>
Component always joins the environment variableAPP_URL
to the href target