developmentseed / osm-teams

Teams for OpenStreetMap!
https://mapping.team
MIT License
26 stars 5 forks source link

Add about page, fix nextlinks #413

Closed LanesGood closed 1 year ago

LanesGood commented 1 year ago

This PR:

  1. Adds an About page with background on the project, references and links to Github and project supporters with logos
  2. Ensures that the Next <Link> Component always joins the environment variable APP_URL to the href target
    • Note: Item 2 is likely required for all non-standard environments
  3. Updates styles on links, text styles, and page navigation buttons
  4. Removes unused icons
  5. Replaces the SVGSquare component with the Badge component

image

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osm-teams ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 2:45AM (UTC)
LanesGood commented 1 year ago

@kamicut please feel free to add to/edit/contribute content for the about page in addition to review

kamicut commented 1 year ago

@LanesGood thanks for the PR! In NextJS, we use the basePath to ensure that Links are correctly formed https://nextjs.org/docs/api-reference/next.config.js/basepath, so we don't need to join the APP_URL with the link path. Is this required for a specific reason in your commit?

LanesGood commented 1 year ago

@kamicut I was simply following the pattern established on other NextLinks throughout the app.

LanesGood commented 1 year ago

@kamicut per our conversation, I've removed all instances of joined APP_URL's from any Nextjs <Link> href in the latest commit.