developmentseed / osm-teams

Teams for OpenStreetMap!
https://mapping.team
MIT License
26 stars 5 forks source link

Redirect invite accepted to team page on success #414

Closed LanesGood closed 1 year ago

LanesGood commented 1 year ago

Redirects the "Invitation accepted" page to the team page of the invite after 3 seconds. This redirect occurs only on a successfully accepted invitation.

Closes #371

-NB, #371 suggests redirecting immediately to the Team profile. Given the possibility of a user not understanding the new team page invite, I propose redirecting only to the team page. This could later highlight the need to edit and fill the profile.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osm-teams ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 1:37PM (UTC)
kamicut commented 1 year ago

@LanesGood This worked! I was a little surprised that we didn't have a confirm before the redirect when going to the URL. When accessing the URL, should we have a "join team" button? We could also have a button that says "take me back to team" or a load indicator that says "redirecting you to team".

LanesGood commented 1 year ago

@kamicut the automatic join is part of the API, as far as I'm aware. This PR doesn't change the existing behavior of the app, which is:

There would need to be an addition to the API to first require a "join team" confirmation. That's out of the scope of this PR but could be a new issue.

LanesGood commented 1 year ago

To update:

LanesGood commented 1 year ago

@kamicut updated with text and manual options: image