search

developmentseed / scoreboard

Encouraging OpenStreetMap mappers with badges, graphs & stats! ✨🕹
https://developmentseed.org/scoreboard
27 stars 9 forks source link

Test efficiency #624

Open jvntf opened 3 years ago

jvntf commented 3 years ago

The test suite is arguably not efficient. It runs seeds before most if not all tests. I suppose this is good for running individual tests but maybe it should just be run once when running the suite? not sure if theres a best practice to follow here.

cc @guidorice @necoline

guidorice commented 3 years ago

👍

Sometimes it's preferable to be able to run a single test from the command line, especially in development. Ideally each test would be able to detect whether the seed data has been loaded, or not, and do the right thing. It seems like the best practice / best implementation here is less clear because of using both ava and jest for test runners.

jvntf commented 3 years ago

tests still time out sometimes.