Closed maxgrossman closed 1 year ago
Probably will merge develop in to the head branch too so this does not look like it is change so many files...
@maxgrossman This page does not work if the user accessing the Timeseries is not an admin. The /api/users
call requires admin privileges. If the Timeseries is an admin feature, it should probably live in the Admin dashboard. If it isn't, then we should relax the /api/users
permissions.
My vote would be keep admin now and figure out best way to relax permissions later.
As for "living in the admin dashboard" do you mean move the link to the main admin page and make the page's route something like /admin/timeseries
?
@maxgrossman I've been confused about something and only now understand: we don't show the data broken out as a timeseries on the timeseries page, only in the CSV download. It looks like the DevSeed team discussed this in 2020, but we didn't resolve the conversation: https://github.com/developmentseed/scoreboard/issues/603#issuecomment-702920433.
Rather than depicting the types of edits, and the counts, the default visualization of the timeseries data should be (as proposed by Neco) the timerseries interval bins. Tables should likewise be focused on interval bins, and likely both the chart and the table would highlight # of edits as the y-axis, and time intervals on the x-axis.
This would be a large change - can we discuss changes needed for this branch? cc @kamicut
What I am changing
This pr fills out the api business logic to return time series data... It also adds ui for users to interact with and download the data
How I did it
How you can test it
will write these steps out in comment below...
Related Issues