search

developmentseed / scoreboard

Encouraging OpenStreetMap mappers with badges, graphs & stats! ✨🕹
https://developmentseed.org/scoreboard
27 stars 9 forks source link

Restrict timeseries chart to top 20 users #709

Closed LanesGood closed 1 year ago

LanesGood commented 1 year ago

This PR restricts the Time Series Edits Chart to the top users, sorted by edit, up to 20. The limit of 20 users is somewhat arbitrary, set only by the amount of vertical space available for the legend.

image

LanesGood commented 1 year ago

Marking this as ready for review @maxgrossman @kamicut. I think the main question here is: do admins want to see timeseries charts with more than 20 users? If so, this PR can be closed. However, I think that the number of bars when there are more than 20 users becomes overwhelming.

maxgrossman commented 1 year ago

I think this is cool. I think that 'top x' users makes lots of sense when filtering for edits by big teams or in a country, but less so when I am just looking for a few users.

Maybe if the query returns less than 20 users 'top x users' gets omitted. Think this could be addressed later. future paginating can address this.