Closed dbdean closed 6 years ago
Don't have a ton of time for a full review but on quick scan this looks good. I'll test it out and merge in sometime in the next week. I also love the idea of the .env
file since it could stand is as "configuration" for multiple dataset preparations. Thanks
Man my "next week" comment looks pretty bad above. Checking this out today and will update. Thanks again @dbdean
Looks to good to merge:
README
change to keep some lines together but then I realized you were being a good gitizen and keeping line lengths trimmed (something I'm terrible at) so I reset and force pushed over my own change@drewbo, the not having root-owned folders in data means that you don't have to use sudo
to access or modify the data when you are not inside of docker, and it also (more importantly) is a side-effect of no longer running the docker container as a privileged user when it is not required to be so, which is generally a good security principle.
Thanks @drewbo!
I was finding some inefficiencies in having to build and run my own local docker instead of using the prebuilt ones, so I set up a single container docker-compose to help out. This PR has the following main changes:
docker-compose build
,docker-compose run data download-osm-tiles
,docker-compose run data
.I have also updated the README to reflect these changes.
I would appreciate any comments you have and are happy to help improve this PR in any way to help get it in.