Ab/use renders keys as layer options

developmentseed / stac-explorer

An explorer (visualizing + simple charting) for data catalogued in STAC and CMR

4 stars 1 forks source link

Ab/use renders keys as layer options #34

Closed abarciauskas-bgse closed 8 months ago

abarciauskas-bgse commented 8 months ago

This is a WIP.

It refactors VariablesSelect to allow for the select options to be the renders keys themselves when no cube:variables is present.

It includes work from #30 and #32 so we can test using it with the HLS data which does not implement the data cube extension.

Issues:

The URLs are being constructed as I would expect but the requests for HLS are returning 204 and I'm not sure why, may require pairing with @vincentsarago

oliverroick commented 8 months ago

@abarciauskas-bgse Your changes look good. The only piece that is missing is the time select in the layers list for HLS layers. I can take care of that if you want. Would that be a time slider or a range select for HLS layers?

abarciauskas-bgse commented 8 months ago

@oliverroick if the titiler cmr api accepts a date range, we can do that otherwise a slider like the other collection is fine.

oliverroick commented 8 months ago

Added a change to enable the time slider for HLS collections

Renamed CubeLayerForm to CmrLayerForm
Made step prop of DateTimeSlider optional, with a default value
Added time support for non-cube layers to CmrLayerForm

abarciauskas-bgse commented 8 months ago

@oliverroick Thank you!

Do you think we could change CmrLayerForm to just LayerForm or StacLayerForm because not all layers will be coming from CMR (for example, once I add a pyramid layer it will not be using CMR and titiler-cmr)

abarciauskas-bgse commented 8 months ago

@oliverroick thanks for making those last changes. I think we can merge this when you are happy with it and we will handle how to show the HLS layers in a separate PR.

abarciauskas-bgse commented 8 months ago

This looks good to me, I've tested all layers.