developmentseed / tecnico-energy-app

https://dashboard-ds-peach.vercel.app/
0 stars 0 forks source link

Should we trim data without metrics/geometries? #26

Closed alukach closed 3 months ago

alukach commented 3 months ago

It's possible that our metrics will reference geometry IDs that aren't available in the geospatial data provided. How should we handle this? We could keep the data, which would affect when we represent total values (ie values where no area-of-interest is provided by a user), or delete it.

Additionally, on the converse, it's possible that we could have polygons without metrics. Should those be displayed in the UI?

yellowcap commented 3 months ago

A case like that is user input error, the assumption is that all data in the tables should have a geometry to attach to. So I would do one of two things

I would not recommend adding it and have it in the calculations when it does not have an "anchor".

alukach commented 3 months ago

In https://github.com/developmentseed/tecnico-energy-app/commit/c42af3b2b9ec226c2246ec0f0978c8ef320bef8e, we've added a feature to enable a user to ingest data in STRICT_MODE. In strict mode, we will fail the ingestion of a metric has no associated geometry. In non-strict mode, we will drop the data and log the issue.