use proj4 string for ST_transform

developmentseed / timvt

PostGIS based Vector Tile server.

https://developmentseed.org/timvt/

MIT License

187 stars 27 forks source link

use proj4 string for ST_transform #66

Closed vincentsarago closed 2 years ago

vincentsarago commented 2 years ago

closes #65, closes #63

This PR does:

compare tile geometry and table geometries in table CRS (#63)
use proj4 string in ST_Transform when TMS's CRS doesn't have a valid EPSG code (#65)
update morecantile requirement
update pre-commit config
add more tests (for TMS support)

TODO

[ ] add a note in the documentation about performances when using non-epsg CRS

vincentsarago commented 2 years ago

latest commit fix most of the performance BUT it made it worse for non-epsg based CRS

here is what really needs to be reviewed

https://github.com/developmentseed/timvt/blob/a0794ac1b498658c9856d42433e6e17e0e1fcd79/timvt/layer.py#L128-L181

latest commit also took care of #63 by executing the WHERE clause using table's geometry SRID

vincentsarago commented 2 years ago

To be honest I can't think of a better solution to support non-epsg CRS. I think I'll add a note about the performance implication of using such CRS.