developmentseed / tipg

Simple and Fast Geospatial OGC Features and Tiles API for PostGIS.
https://developmentseed.org/tipg/
MIT License
153 stars 23 forks source link

split OGC Features and Tiles endpoints factories #32

Closed vincentsarago closed 1 year ago

vincentsarago commented 1 year ago

closes #6

This PR split the endpoint factory in two: OGCFeaturesFactory and OGCTilesFactory which should enable user to build either the tiles service or features service individually.

The main issue is for creating the OGC features landing and conformances endpoints. I've added two ways:

IMO it's really annoying that both / and /conformance are part of the features specification šŸ˜¬

Screenshot 2023-02-28 at 9 47 15 AM
vincentsarago commented 1 year ago

@bitner any of this make sense? šŸ˜„

vincentsarago commented 1 year ago

latest version of FastAPI/starlette changed something in url_for https://github.com/encode/starlette/pull/2050 which breaks tipg (and other project where I use url_path_for šŸ˜¬ ) šŸ¤·

vincentsarago commented 1 year ago

šŸ˜¬ it's the output of url_for which was a string before and now is of type URLpath

see https://github.com/encode/starlette/pull/1385

vincentsarago commented 1 year ago

last commit refactored a bit how we add the OGC common endpoints. It's now defined at the base class level.

To Do

vincentsarago commented 1 year ago

@bitner this is ready šŸ™