developmentseed / tipg

Simple and Fast Geospatial OGC Features and Tiles API for PostGIS.
https://developmentseed.org/tipg/
MIT License
143 stars 19 forks source link

Allow for Write/Delete/Update on Features #92

Open EPajares opened 1 year ago

EPajares commented 1 year ago

Intro

Thanks for this interesting project! I was coming across the project on my search for an OGC-compliant Webserver. In particular I like the perfect integration with FastAPI. At the moment we are having some custom functionality for CRUD on Geofeatures in our application, but we are aiming to make use of a library such as tipg to have things more generic.

Question

Meanwhile, as far as I understand tipg is aiming to be "Read-only", meaning there is no Create, Update and Delete. I get the reasoning behind this and in many projects this is fine. As for us we would need full CRUD I was just wondering if you would welcome a contribution implementing Create, Update and Delete for the Features?

(This is just meant to be a hypothetical question at the moment as we have not yet decided using tipg.)

vincentsarago commented 1 year ago

👋

my search for an OGC-compliant

FYI, apparently we do not comply totally with the spec #84 but we tried to follow the specs as best as we could

As for us we would need full CRUD I was just wondering if you would welcome a contribution implementing Create, Update and Delete for the Features?

Absolutely, the write part is going to be added in Part 4 of the OGC spec https://docs.ogc.org/DRAFTS/20-002.html so I believe we could totally add it maybe part of an options in the OGCFeaturesFactory

we have not yet decided using tipg

Let us know if there are things we can do better 🙏

krishnaglodha commented 1 year ago

I'd be available for this issue if needed :)

EPajares commented 1 year ago

Thank you for your immediate reaction! I understand concerning the OGC compliance, this is something I need to further check in our use case. Let me study the codebase bit more and get back to you.