Closed emileten closed 6 months ago
@vincentsarago should we change the Dockerfile -- now we only have the one based on your gunicorn-uvicorn image -- so that it starts the app with uvicorn
?
now we only have the one based on your gunicorn-uvicorn image -- so that it starts the app with uvicorn ?
I think it's fine as it is, people could just pass a CMD
parameter to start uvicorn instead of Gunicorn
This PR:
publish-docker
job to the CI github action. Inspired from the titiler-pgstac one, except that here we're only publishing the image based on the rootgunicorn-uvicorn
image.uvicorn
-only dockerfile and references to it, and renames the gunicorn+uvicorn based dockerfile toDockerfile
. We're only going to use this one.As a reminder, docker build and push to ghcr will happen when :
main
, in which case a docker image taggedlatest
is pushed