developmentseed / titiler

Build your own Raster dynamic map tile services
https://developmentseed.org/titiler/
MIT License
787 stars 162 forks source link

sketch use of Annotated types #612

Closed vincentsarago closed 1 year ago

vincentsarago commented 1 year ago

Possible fix for using Optional Path parameter when multiple routes are defined

ref https://github.com/tiangolo/fastapi/discussions/9278

vincentsarago commented 1 year ago

While the tests pass, I don't think the solution is 👍

Removing the use of Query/Path and use simple Annotated type means that we are loosing OpenAPI description/title.

I've opened https://github.com/tiangolo/fastapi/pull/9670 to see if we can do something about it

vincentsarago commented 1 year ago

I'm going to move forward with this PR because: