devendra-alt / ES6-todo-list

ES6 based basic todo list
https://devendra-alt.github.io/ES6-todo-list/dist
MIT License
5 stars 0 forks source link

Morning session: peer-to-peer code reviews #11

Open Log-benjamin opened 1 year ago

Log-benjamin commented 1 year ago

🎖️ Good work on implementing the requirements on your app. You have implemented most of the task

👨‍💻 highlights ✔️ Modules being used ✔️ Functional choices are exceptional

Suggestions to Improve Your App

🌟Try to use a separate directory for your modules. 🌟 Please try to fix the add task input by setting a condition. The enter key is passing an empty value which it should not do. 🌟 Consider using event delegation instead of attaching individual event listeners to each checkbox element. This can boost performance, especially with a large number of checkboxes. 🕹️ 🌟 Refactor the code to pass localStorage as a parameter to setTasks and getTasks. This enhances testability and code reuse by allowing easy mocking or replacement of localStorage. 🗂️

devendra-alt commented 1 year ago

Thank You @Log-benjamin For your valuable suggestions 💯 , I will work on it