search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
149 stars 62 forks source link

Add project directory as public included directory #19

Closed chaplin89 closed 5 years ago

chaplin89 commented 5 years ago

I've tried to use cminpack but unfortunately, I had to add the cminpack root folder before being able to compile the program.

This simple edit edit serve only to expose the root directory to whoever does a target_link_libraries(${PROJECT} cminpack) and thus avoid adding other target_include_directory()in projects that uses cminpack.

devernay commented 5 years ago

@xantares @edisongustavo @fernape can one of you please review this PR? I am not confident enough with cmake to merge this without your review

edisongustavo commented 5 years ago

@devernay I will take a look

xantares commented 5 years ago

-1, you should use the INTERFACE argument, and use INSTALL_INTERFACE / install prefix

chaplin89 commented 5 years ago

Thanks, I'll open another PR.