search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

Exported include dir and CMINPACK_NO_DLL #23

Closed chaplin89 closed 5 years ago

chaplin89 commented 5 years ago

As with the previous PR, I exported the include directory this time as an INTERFACE property.

Also, I changed add_definitions with a target_compile_definitions for the macro CMINPACK_NO_DLL. This time, I used PUBLIC, as it is needed either for building cminpack itself and either for building other projects (CMINPACK_NO_DLL it is used for defining CMINPACK_EXPORT inside cminpack.h).

Note: CMINPACK_EXPORT expand in __declspec(dllimport) if CMINPACK_NO_DLL is not defined. On the other hand, this CMake script will build cminpack with CMINPACK_NO_DLL defined if no preferences are specified, so possible compilation issues can arise if you're trying to integrate cminpack from a subdirectory (without install).

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.105% when pulling 97699e2ef4fa2a3633a4abe3f603636c93587831 on chaplin89:master into d9557c3f425b03922fff8e851a25d231312f876f on devernay:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.105% when pulling 97699e2ef4fa2a3633a4abe3f603636c93587831 on chaplin89:master into d9557c3f425b03922fff8e851a25d231312f876f on devernay:master.