search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
149 stars 62 forks source link

1.3.7 release #25

Closed tadeu closed 3 years ago

tadeu commented 5 years ago

Hi @devernay! First, thanks for maintaining this project, it's awesome to have an actually maintained "alternative" to the very old Fortran MINPACK! I'd like to know if there are plans for a new 1.3.7 release (or if it could be released soon), because I'd like to create packages for cminpack on conda-forge. Thanks!

tadeu commented 5 years ago

But perhaps let's wait, I'll start a work-in-progress PR there in conda-forge and let you know

devernay commented 5 years ago

is there anything in 1.3.6 that doesn't work for you? You should really consider using it, since it's very stable

tadeu commented 5 years ago

I'm trying to build on 1.3.6 there right now: https://github.com/conda-forge/staged-recipes/pull/7766

I had to add a patch with a fix for some examples (the examples are being built & run as a way to test the package), but besides that, it seems fine.

Note that this first version there is built without BLAS support (I'm interested in hybrj, which doesn't seem to use BLAS). For using MKL's BLAS (specially for Windows) we would probably need a new release, since FindMKL.cmake was only added recently.

devernay commented 4 years ago

what was wrong with tlmdif?

devernay commented 4 years ago

(I will do the 1.3.7 release, unless there is something wrong with tlmdif)

tadeu commented 4 years ago

what was wrong with tlmdif?

Ahh, I don't remember it exactly, but some results were slightly different from the expected values in the test when using OpenBLAS, e.g., 0.002869942 instead of 0.002869941. But I think it was related more to the choice of BLAS library than to the 1.3.6 release.

xantares commented 3 years ago

any news on this ? for me, it's the fact that cminpack does not correctly link to cblas that is annoying (#21) with the 1.3.6 regards

devernay commented 3 years ago

done!

xantares commented 3 years ago

thanks!