search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

Revert "Dont use cmake LOCATION property" #26

Closed devernay closed 5 years ago

devernay commented 5 years ago

Reverts devernay/cminpack#22

devernay commented 5 years ago

Initial PR #22 broke the appveyor vuild, see https://ci.appveyor.com/project/devernay/cminpack/builds/22314483 Asked @xantares for a revised fix

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.105% when pulling e2f9cb5f6ba0b9aa9d9d6feb9f15e61ec5e2675a on revert-22-location into 74f1b8258e99336788a13799505c2c7d7dd333b0 on master.

tadeu commented 5 years ago

There are a lot of warnings that look related to this in the build:

CMake Warning (dev) at examples/CMakeLists.txt:22 (get_target_property):
  Policy CMP0026 is not set: Disallow use of the LOCATION target property.
  Run "cmake --help-policy CMP0026" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
  The LOCATION property should not be read from target "tchkder_".  Use the
  target name directly with add_custom_command, or use the generator
  expression $<TARGET_FILE>, as appropriate.
Call Stack (most recent call first):
  examples/CMakeLists.txt:37 (add_minpack_test)
This warning is for project developers.  Use -Wno-dev to suppress it.
devernay commented 5 years ago

This is being fixed, see #29 The previous PR (#22) broke the appveyor build