Fixes wrong `CMINPACK_LIBRARIES` in WIN32

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems

http://devernay.free.fr/hacks/cminpack/

145 stars 63 forks source link

Fixes wrong `CMINPACK_LIBRARIES` in WIN32 #31

Closed tadeu closed 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 94.105% when pulling a0106fb43c3f0443e720f4c8399e1f7c379ed6fb on tadeu:fix-cmake-win32 into 284805ef62f6cbe42f840e7c30f104962f13f4c2 on devernay:master.

coveralls commented 5 years ago

Coverage remained the same at 94.105% when pulling a0106fb43c3f0443e720f4c8399e1f7c379ed6fb on tadeu:fix-cmake-win32 into 284805ef62f6cbe42f840e7c30f104962f13f4c2 on devernay:master.

devernay commented 5 years ago

Thank you! Please use a proper description in PR, and avoid reformatting existing code, even if you do not like extra spaces. I ended up changing the 3 lines manually, see https://github.com/devernay/cminpack/commit/b25f168fec6e6ccbc8c36b119d9ba52e4999eaa8

tadeu commented 5 years ago

Sure, the reformatting was not on purpose, it was automatically done by my editor, and I was configured to not see whitespaces in the diff :)