search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

CMakeLists.txt: add_library should be after postfixs are defined #33

Closed bherisse closed 5 years ago

bherisse commented 5 years ago

Hi, I propose slight modifications to be consistent with new version of CMinPack. Moreover, it seems that the add_library has to be set after postfix definition, otherwise, it is not considered (using Visual C++ at least). Thank you very much for your great work on this project. Bruno

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.105% when pulling cea0263603409e12b210c4e7ca0edb025c632649 on bherisse:patch-1 into acb96dedf75c483acdd5c56ea4de16476cd7c82d on devernay:master.

devernay commented 5 years ago

Can another Visual Studio user review this? @haferburg @tadeu @xantares @chaplin89 @edisongustavo maybe?

devernay commented 5 years ago

Validated by @bherisse on Visual Studio 2015, Linux (GCC 8), MinGW (CodeBlocks)