search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

update tools path to bin for newer mkl (2020.1.217) #51

Closed acxz closed 3 years ago

acxz commented 3 years ago

With the newer intel mkl versions the path for tools has changed to bin. I am sure a better solution can be thought of that uses the version information. This is a patch solution for now.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 94.105% when pulling 9fa5180a357af59f4167d194ebf83105e2d550de on acxz:bin-tools into 0d40c5359674448aa6f78accaddca1d79befff1f on devernay:master.

xantares commented 3 years ago

your patch may break older mkl installs I think find_program is the way to go, testing both locations, can you try that:

find_program (MKL_LINK_TOOL NAMES mkl_link_tool HINTS ${MKL_ROOT_DIR}/bin ${MKL_ROOT_DIR}/tools)

also, I think it takes care of the .exe extension that is appended manually just after the set line.

acxz commented 3 years ago

Definitely it will break older mkl installs.

Yeah find_program is a great suggestion.

Edit: It worked for me, here is the PR for it #52