search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

Malformed version in generated pkgconfig file #55

Closed StefanBruens closed 1 year ago

StefanBruens commented 1 year ago

The CMINPACK_VERSION variable contains a semicolon separated list of strings: https://github.com/devernay/cminpack/blob/262edbdc674431e08d9441790cf5cc6d040d701d/CMakeLists.txt#L17

i.e. 1.3.9;STRING;CMinpack\ version. See https://cmake.org/cmake/help/latest/command/set.html#set :

Multiple arguments will be joined as a semicolon-separated list to form the actual variable value to be set.

After https://github.com/devernay/cminpack/blob/262edbdc674431e08d9441790cf5cc6d040d701d/CMakeLists.txt#L174

the pkgconfig file contains the following Version field:

Version: 1.3.8;STRING;CMinpack version
devernay commented 1 year ago

Thanks! can you please contribute a fix (by way of PR)?