search

devernay / cminpack

A C/C++ rewrite of the MINPACK software (originally in FORTRAN) for solving nonlinear equations and nonlinear least squares problems
http://devernay.free.fr/hacks/cminpack/
145 stars 63 forks source link

Initial Github Actions covering latest Ubuntu and Visual Studio builds through CMake #59

Closed luau-project closed 3 months ago

luau-project commented 7 months ago

What?

I have added github actions to build, test, and install cminpack through CMake on the latest Ubuntu and Visual Studio github images.

Why?

These additions are valuable to people learning and experimenting cminpack, and also for people working on cminpack forks to inspect and get a quick test response on their pushes.

How?

Note 1: Both workflows build + test + install on multiple conditions (shared libraries on/off, build types release/debug/relwithdebinfo/minsizerel) and Visual Studio also builds and tests on multiple architectures (x64 / Win32). However, since the reference tests only seem to work well with cminpack double precision version, it is the only precision used in the workflows.

Testing?

  1. The github action .github/workflows/ubuntu-cminpack-install.yaml works out of the box on latest Ubuntu
  2. The github action .github/workflows/windows-visual-studio-cminpack-install.yaml works out of the box on latest Windows + latest Visual Studio

Note 2: On a local virtual machine, I am able to build, test and install cminpack on Windows 11 through CMake with GCC + GNU Make provided by MSYS2. However, it is failing on a sketch workflow on github actions which I am still diagnosing the issue. It might come in the future if I manage to fix it.

devernay commented 3 months ago

Nice! do you need me to configure something on the repo itself? (I never configured GH actions)

luau-project commented 3 months ago

Hello @devernay . Nice that you merged these additions. I saw that you are preparing for a v1.3.9 release. Please, just wait a few days for me to fix these github build C.I.

Recently, I noticed that they are bugged, because I didn't know very well how they worked.

Now, I am fully aware how Github Actions work and I can greatly improve it.

devernay commented 3 months ago

Cool. I merged them in knowing this wwas WIP. Please submit fixes asap. Thank you!