search

devexp-db / distgen

Distribution oriented templating system
http://distgen.readthedocs.io/
GNU General Public License v2.0
18 stars 13 forks source link

centos and cestos-stream have the same id #120

Closed frenzymadness closed 1 year ago

frenzymadness commented 2 years ago

In S2I Python container, we have some conditions based on config.os.id and I've discovered that Centos stream has the same id as Centos. I believe that those systems are very different and therefore they should have different ids in distgen.

Am I wrong?

Cc: @phracek

phracek commented 2 years ago

I guess, we have to create a new config file called centos-stream.yaml with different id. I Does it make sense?

phracek commented 2 years ago

Similar to this one https://github.com/devexp-db/distgen/blob/main/distgen/distconf/lib/centos.yaml

frenzymadness commented 2 years ago

There already is a file for centos stream but it inherits the id from centos, see: https://github.com/devexp-db/distgen/blob/main/distgen/distconf/centos-stream-9-x86_64.yaml

frenzymadness commented 1 year ago

Fixed in https://github.com/devexp-db/distgen/commit/350e90fc803167435282c433cc57c721992dbb6a