devexp-db / distgen

Distribution oriented templating system
http://distgen.readthedocs.io/
GNU General Public License v2.0
18 stars 13 forks source link

Add `include` to multispec matrix #129

Closed frenzymadness closed 2 years ago

frenzymadness commented 2 years ago

This adds a possibility to use include in a multispec matrix which is useful when you have a lot of possible combinations but you are interested only in a few of them. In that case, include is also easier to maintain when you add a new version into the multispec.

I did a little bit of refactoring because the method check_matrix_combinations had multiple purposes – it returned True/False for all matrix combinations and a data structure for combination_extras.

And now:

Having both include and exclude in a single matrix is prohibited.

Tests are adjusted and some of them are new for the new functionality.

Fixes: #128

frenzymadness commented 2 years ago

Thank you for this PR. I did not find any issue with it. LGTM.

Thanks for the review! Will we wait for another one from the team?

praiskup commented 2 years ago

Will we wait for another one from the team?

No need to, my 2c. But +1 from me, too.

zmiklank commented 2 years ago

Great, I will also create a new release today or tomorrow.