search

devexp-db / distgen

Distribution oriented templating system
http://distgen.readthedocs.io/
GNU General Public License v2.0
18 stars 13 forks source link

ci: enable PyLint for pull-requests #132

Closed praiskup closed 1 year ago

github-advanced-security[bot] commented 1 year ago

You have successfully added a new vcs-diff-lint configuration .github/workflows/python-diff-lint.yml:python-lint-job. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

praiskup commented 1 year ago

@zmiklank do you think this change makes sense for this project?

zmiklank commented 1 year ago

@zmiklank do you think this change makes sense for this project?

@praiskup Yes, I think pylint for every pull request is great thing. I personally sometimes forget to run linters before creating PR, so this would be a big help also for me.

praiskup commented 1 year ago

I, however, can not really do a proper review, as I am not sure what pylint settings are needed in the pylintrc that you included.

That is just some default that we use in other projects; it can be tweaked later. If you want me to fix something right now, please tell.

zmiklank commented 1 year ago

I, however, can not really do a proper review, as I am not sure what pylint settings are needed in the pylintrc that you included.

That is just some default that we use in other projects; it can be tweaked later. If you want me to fix something right now, please tell.

I am OK with this default.

praiskup commented 1 year ago

I am OK with this default.

So the change is blessed! Thank you for looking.