devexp-db / distgen

Distribution oriented templating system
http://distgen.readthedocs.io/
GNU General Public License v2.0
18 stars 13 forks source link

Fix release type for github workflows, switch to new auth #146

Closed SlouchyButton closed 3 months ago

SlouchyButton commented 3 months ago

workflow_dispatch: allows us to start the workflow manually in case something fails.

Type published fires only when actually publishing the release. create also fires when draft is created/saved, so when you upload files to the release, it will automatically save it as draft. For security reasons, GitHub doesn't start workflow when create event is fired, if it doesn't also publish the release at the same time.

This can seemingly work in some repositories where no additional files are uploaded when doing the release, but that's not the case here.

https://docs.github.com/en/webhooks/webhook-events-and-payloads#release https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release

From GitHub docs:

Note: Workflows are not triggered for the created, edited, or deleted activity types for draft releases. When you create your release through the GitHub browser UI, your release may automatically be saved as a draft.

PR also removes the password field as PyPi uses new auth methods.