devexperts / dx-platform

Mozilla Public License 2.0
33 stars 24 forks source link

ci: Redundant storybook publishes #174

Closed sutarmin closed 5 years ago

sutarmin commented 5 years ago

Occasionally noticed that travis CI build (pr phase) is running against the master branch and therefore redeploys storybook in each PR check.

A possible fix is to make the check in after_success step stricter by checking TRAVIS_EVENT_TYPE variable.

sutarmin commented 5 years ago

Looks like I misspelled env variable name (forgot $), now it's not running even on master

sutarmin commented 5 years ago

Fixed in #179, thanks @raveclassic