search

devexperts / dxcharts-lite

Flexible financial charts based on HTML5 canvas
https://devexperts.com/dxcharts/
Mozilla Public License 2.0
45 stars 9 forks source link

Source code published with releases has the wrong `package.json` version #160

Closed Aghassi closed 4 months ago

Aghassi commented 5 months ago

Duplicates

Latest version

Describe the bug 😯

Your release process is not bumping the package.json before tar'ing up the source code put with each release on github. This means pulling 2.4.6 pulls 2.4.5 technically if you pull the github tgz.

Link to minimal reproduction

Download the tar for the latest release

Steps to Reproduce the Bug or Issue 🕹

Download the tar and untar it, Validate the package.json version in the resulting folder

Expected behavior 🤔

package.json version should match the version on github

Platform

Applies across the board

Additional context 🔦

No response

disyakidneyshot commented 5 months ago

Hello there @Aghassi! Yep, you're right, thanks for your report We will work it out

disyakidneyshot commented 4 months ago

@Aghassi we changed release flow to escape this issue Since @2.5.0 everything should be fine :)

P.S. here you can find main changes in release job https://github.com/devexperts/dxcharts-lite/commit/3a5c6f5016ebdb05f4dbd7d468cf0406cbfcaf03