search

devfd / react-native-workers

Background services and web workers for react-native
BSD 2-Clause "Simplified" License
804 stars 89 forks source link

compile with RN 0.40.0 #24

Open weixingsun opened 7 years ago

weixingsun commented 7 years ago

works in ios, only compiled in android

keinsolrac commented 7 years ago

Hi, Thanks for your contribution In the simulator works perfect, but in my phone closes the application, I have Android 5.1 know something about it?

weixingsun commented 7 years ago

Hi, sorry I don't have android in hands, maybe you can check the worker files written in WorkerModule.java: "assets://workers/" + jsFileSlug + ".bundle"

ousat commented 7 years ago

@keinsolrac I had not defined assets location , I placed worker.js outside along with index.android.js , it worked fine

@weixingsun thanks for the build it works fine for android too

vexsnare commented 7 years ago

Can this be merged ?

gustarus commented 7 years ago

@devfd, we need this feature as soon as possible! Please, cloud you accept this pull request?