devfile / api

Kube-native API for cloud development workspaces specification
Apache License 2.0
257 stars 61 forks source link

move filesystem related code out of testingutils in devfile Library #1198

Open yangcao77 opened 1 year ago

yangcao77 commented 1 year ago

Which area/kind this issue is related to?

/area library

Issue Description

currently library has filesystem code under testingutils: https://github.com/devfile/library/tree/main/pkg/testingutil/filesystem

however, the filesystem is been used in the devfileObj.ctx: https://github.com/devfile/library/blob/6c4a5b8686baa12ddb7155a84708318757a9f32e/pkg/devfile/parser/context/fs.go#L18-L23 it does not make sense, and it's a very bad code structure that one of the objects from the devfileObj struct is from the testingutil.

we should move the general filesystem related code to under pkg.

Target Odo version

Target Odo version:

github-actions[bot] commented 11 months ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.